linux-kernel - Re: [PATCH net] net: fec: fix improper use of NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 09:30:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     qiangqing.zhang@....com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, B38611@...escale.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: fec: fix improper use of NETDEV_TX_BUSY

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Fri, 28 Oct 2022 10:09:11 +0800 you wrote:
> The ndo_start_xmit() method must not free skb when returning
> NETDEV_TX_BUSY, since caller is going to requeue freed skb.
> 
> Fix it by returning NETDEV_TX_OK in case of dma_map_single() fails.
> 
> Fixes: 79f339125ea3 ("net: fec: Add software TSO support")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> 
> [...]

Here is the summary with links:
  - [net] net: fec: fix improper use of NETDEV_TX_BUSY
    https://git.kernel.org/netdev/net/c/06a4df5863f7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html