linux-kernel - Re: [PATCHv1 2/8] ARM: dts: at91: sam9x60: remove flexcom definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <51b5b965-bd5e-25f5-4bdc-1f3fc9e21168@microchip.com>
Date:   Mon, 31 Oct 2022 10:23:54 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Durai.ManickamKR@...rochip.com>, <Nicolas.Ferre@...rochip.com>,
        <Cristian.Birsan@...rochip.com>, <Hari.PrasathGE@...rochip.com>,
        <davem@...emloft.net>, <krzysztof.kozlowski+dt@...aro.org>,
        <alexandre.belloni@...tlin.com>, <arnd@...db.de>, <olof@...om.net>,
        <soc@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <Manikandan.M@...rochip.com>,
        <Kavyasree.Kotagiri@...rochip.com>, <Horatiu.Vultur@...rochip.com>
Subject: Re: [PATCHv1 2/8] ARM: dts: at91: sam9x60: remove flexcom definitions

On 31.10.2022 05:36, Durai Manickam KR wrote:
> Remove the flexcom definitions in the board specific DTS file of sam9x60ek.
> 
> Signed-off-by: Durai Manickam KR <durai.manickamkr@...rochip.com>
> ---
>  arch/arm/boot/dts/at91-sam9x60ek.dts | 35 +---------------------------
>  1 file changed, 1 insertion(+), 34 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
> index 265978514dcf..9d9e50c77794 100644
> --- a/arch/arm/boot/dts/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
> @@ -211,15 +211,10 @@ &flx0 {
>  	status = "okay";
>  
>  	i2c0: i2c@600 {
> -		compatible = "microchip,sam9x60-i2c";
> -		reg = <0x600 0x200>;
> -		interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> -		clocks = <&pmc PMC_TYPE_PERIPHERAL 5>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_flx0_default>;
> -		atmel,fifo-size = <16>;
>  		i2c-analog-filter;
>  		i2c-digital-filter;
>  		i2c-digital-filter-width-ns = <35>;
> @@ -239,16 +234,8 @@ &flx4 {
>  	status = "disabled";
>  
>  	spi4: spi@400 {
> -		compatible = "microchip,sam9x60-spi", "atmel,at91rm9200-spi";
> -		reg = <0x400 0x200>;
> -		interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
> -		clocks = <&pmc PMC_TYPE_PERIPHERAL 13>;
> -		clock-names = "spi_clk";
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_flx4_default>;
> -		atmel,fifo-size = <16>;

As mention in the previous version, this starting here

> -		#address-cells = <1>;
> -		#size-cells = <0>;

ending here is not moved to dtsi but was just deleted. Please include it in
another patch.

Also, you will have to merge this patch with the next to have the
components removed here still working in this patch.

>  		status = "disabled";
>  	};
>  };
> @@ -258,23 +245,8 @@ &flx5 {
>  	status = "okay";
>  
>  	uart5: serial@200 {
> -		compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> -		reg = <0x200 0x200>;
> -		atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
> -		interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> -		dmas = <&dma0
> -			(AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) |
> -			 AT91_XDMAC_DT_PERID(10))>,
> -		       <&dma0
> -			(AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) |
> -			 AT91_XDMAC_DT_PERID(11))>;
> -		dma-names = "tx", "rx";
> -		clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
> -		clock-names = "usart";
> -		pinctrl-0 = <&pinctrl_flx5_default>;
>  		pinctrl-names = "default";
> -		atmel,use-dma-rx;
> -		atmel,use-dma-tx;
> +		pinctrl-0 = <&pinctrl_flx5_default>;
>  		status = "okay";
>  	};
>  };
> @@ -284,15 +256,10 @@ &flx6 {
>  	status = "okay";
>  
>  	i2c6: i2c@600 {
> -		compatible = "microchip,sam9x60-i2c";
> -		reg = <0x600 0x200>;
> -		interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> -		clocks = <&pmc PMC_TYPE_PERIPHERAL 9>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_flx6_default>;
> -		atmel,fifo-size = <16>;
>  		i2c-analog-filter;
>  		i2c-digital-filter;
>  		i2c-digital-filter-width-ns = <35>;