[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 31 Oct 2022 09:33:07 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Christoph Hellwig <hch@...radead.org>,
Yu Kuai <yukuai1@...weicloud.com>
Cc: tj@...nel.org, josef@...icpanda.com, axboe@...nel.dk,
cgroups@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
"yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH -next 4/5] blk-iocost: fix sleeping in atomic context
warnning in ioc_qos_write()
Hi,
在 2022/10/30 17:55, Christoph Hellwig 写道:
> This seems a little convoluted to me. I'd suggest to add a new
> sleeping lock that protects the updates, then you just take the
> spinlock after parsing without much other changes.
>
> (The same comment also applies to patch 5).
Yes, add a new sleeping lock is ok, and changes will be much simpler.
Thanks for the suggestion, I'll send a new verion soon.
Kuai
> .
>
Powered by blists - more mailing lists