linux-kernel - RE: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB5925F9A7B8E075C4F9762D30E1379@AM6PR04MB5925.eurprd04.prod.outlook.com>
Date:   Mon, 31 Oct 2022 10:55:07 +0000
From:   Joy Zou <joy.zou@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>
CC:     "S.J. Wang" <shengjiu.wang@....com>,
        "martink@...teo.de" <martink@...teo.de>,
        "dev@...xeye.de" <dev@...xeye.de>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        Peng Fan <peng.fan@....com>, "david@...t.cz" <david@...t.cz>,
        "aford173@...il.com" <aford173@...il.com>,
        Hongxing Zhu <hongxing.zhu@....com>,
        dl-linux-imx <linux-imx@....com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx
 sdma to DT schema


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 2022年10月28日 10:01
> To: Joy Zou <joy.zou@....com>; vkoul@...nel.org; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com
> Cc: S.J. Wang <shengjiu.wang@....com>; martink@...teo.de;
> dev@...xeye.de; alexander.stein@...tq-group.com; Peng Fan
> <peng.fan@....com>; david@...t.cz; aford173@...il.com; Hongxing Zhu
> <hongxing.zhu@....com>; dl-linux-imx <linux-imx@....com>;
> dmaengine@...r.kernel.org; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx
> sdma to DT schema
> 
> Caution: EXT Email
> 
> On 26/10/2022 23:01, Joy Zou wrote:
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: 2022年10月26日 22:59
> >> To: Joy Zou <joy.zou@....com>; vkoul@...nel.org; robh+dt@...nel.org;
> >> krzysztof.kozlowski+dt@...aro.org; shawnguo@...nel.org;
> >> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com
> >> Cc: S.J. Wang <shengjiu.wang@....com>; martink@...teo.de;
> >> dev@...xeye.de; alexander.stein@...tq-group.com; Peng Fan
> >> <peng.fan@....com>; david@...t.cz; aford173@...il.com; Hongxing Zhu
> >> <hongxing.zhu@....com>; dl-linux-imx <linux-imx@....com>;
> >> dmaengine@...r.kernel.org; devicetree@...r.kernel.org;
> >> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> >> Subject: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert
> >> imx sdma to DT schema
> >>
> >> Caution: EXT Email
> >>
> >> On 25/10/2022 04:36, Joy Zou wrote:
> >>> Convert the i.MX SDMA binding to DT schema format using json-schema.
> >>>
> >>> The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma,
> >>> fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to
> >>> delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and
> >>> fsl,imx6sl-sdma are added. The original binding don't list all compatible
> used.
> >>>
> >>> In addition, add new peripheral types HDMI Audio.
> >>>
> >>> Signed-off-by: Joy Zou <joy.zou@....com>
> >>> ---
> >>> Changes in v8:
> >>> add the dma-controller quotes.
> >>
> >> Why adding quotes?
> > I refer to your comments in patch v7/1. The comment as follow:
> > +maintainers:
> > +  - Joy Zou <joy.zou@....com>
> > +
> > You need to reference dma-controller.yaml schema.
> 
> Yes, you need to reference dma-controller.yaml. Nothing about quotes.
> Reference is "$ref: .....yaml"
> 
> 
> > +properties:
> > +  compatible:
> > +    one of:
> > I misunderstand that add the dma-controller.yaml quotes.
> 
> There was nothing about quotes - ".
> 
> > So I am a little confused. Now, I see.
> > should I add dma-common.yaml quotes but not the dma-controller?
> 
> Just drop "
Thank you very much for your comments.
I have changed in patch v9.
BR
Joy Zou
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wiki
> pedia.org%2Fwiki%2FQuotation_mark&amp;data=05%7C01%7Cjoy.zou%40nx
> p.com%7C01a8f1df618e4811dec208dab8884860%7C686ea1d3bc2b4c6fa92c
> d99c5c301635%7C0%7C0%7C638025192713842798%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=UTq378xCa%2Bi4uj0IKxO1lDHpf
> YnKColWT33OVV0T3zE%3D&amp;reserved=0
> 
> Best regards,
> Krzysztof