linux-kernel - Re: [PATCH v2] mfd: mt6360: add bound check in regmap read/write function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1/TO+mOrwjj3D33@google.com>
Date:   Mon, 31 Oct 2022 13:52:59 +0000
From:   Lee Jones <lee@...nel.org>
To:     cy_huang <u0084500@...il.com>
Cc:     matthias.bgg@...il.com, gene_chen@...htek.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ChiYuan Huang <cy_huang@...htek.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] mfd: mt6360: add bound check in regmap read/write
 function

On Thu, 29 Sep 2022, cy_huang wrote:

> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> Fix the potential risk for null pointer if bank index is over the maximum.
> 
> Refer to the discussion list for the experiment result on mt6370.
> https://lore.kernel.org/all/20220914013345.GA5802@cyhuang-hp-elitebook-840-g3.rt/
> If not to check the bound, there is the same issue on mt6360.
> 
> Fixes: 3b0850440a06c (mfd: mt6360: Merge different sub-devices I2C read/write)
> Cc: stable@...r.kernel.org
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
> Since v2:
> - Assign i2c bank variable after bank index is already checked.
> 
> ---
>  drivers/mfd/mt6360-core.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]