[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <80107081-1c24-19d3-9a34-0ee61ac7c99d@huawei.com>
Date: Mon, 31 Oct 2022 21:56:59 +0800
From: cuigaosheng <cuigaosheng1@...wei.com>
To: Christoph Hellwig <hch@...radead.org>
CC: <viro@...iv.linux.org.uk>, <dhowells@...hat.com>,
<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: fix undefined behavior in bit shift for SB_NOUSER
> Let's mark all of the flags as unsigned instead of just one so that
> we don't mix types. s_flags is already unsigned (although for some
> reason long) already.
>
> And while you touch this please add the proper whitespaces around the
> shift operator everywhere.
Thanks for taking time to review this patch, I have made patch v2 and submit it.
On 2022/10/31 21:15, Christoph Hellwig wrote:
> Let's mark all of the flags as unsigned instead of just one so that
> we don't mix types. s_flags is already unsigned (although for some
> reason long) already.
>
> And while you touch this please add the proper whitespaces around the
> shift operator everywhere.
Powered by blists - more mailing lists