linux-kernel - Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6858acf3-eb90-41aa-b714-a2ceb6afe9db@linaro.org>
Date:   Mon, 31 Oct 2022 16:35:38 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Lee Jones <lee@...nel.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Satya Priya <quic_c_skakit@...cinc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Andy Gross <agross@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-input@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

Hi,

On 31/10/2022 16:32, Lee Jones wrote:
> On Fri, 21 Oct 2022, Neil Armstrong wrote:
> 
>> The PM8018 compatible is always used with PM8921 fallback, so PM8018
>> compatible can be safely removed from device ID table
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> 
> Tags should appear chronologically.

Indeed, they were added by b4, I'll report this.

Thanks,
Neil

> 
> I've fixed this up and applied the patch, thanks.
> 
>> ---
>>   drivers/mfd/qcom-pm8xxx.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
>> index 2f2734ba5273..601106580e2e 100644
>> --- a/drivers/mfd/qcom-pm8xxx.c
>> +++ b/drivers/mfd/qcom-pm8xxx.c
>> @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = {
>>   };
>>   
>>   static const struct of_device_id pm8xxx_id_table[] = {
>> -	{ .compatible = "qcom,pm8018", .data = &pm8xxx_data},
>>   	{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
>>   	{ .compatible = "qcom,pm8821", .data = &pm8821_data},
>>   	{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},
>>
>