linux-kernel - Re: [PATCH] scsi: BusLogic: remove variable adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3cae093-6acf-35e5-8411-789383f93337@gonehiking.org>
Date:   Mon, 31 Oct 2022 10:13:31 -0600
From:   Khalid Aziz <khalid@...ehiking.org>
To:     Colin Ian King <colin.i.king@...il.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: BusLogic: remove variable adapter_count

On 10/31/22 10:05, Colin Ian King wrote:
> Variable adapter_count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/scsi/BusLogic.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)

Looks good to me.

Acked-by: Khalid Aziz <khalid@...ehiking.org>


> 
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index f2abffce2659..f7b7ffda1161 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2198,7 +2198,7 @@ static int blogic_slaveconfig(struct scsi_device *dev)
>   
>   static int __init blogic_init(void)
>   {
> -	int adapter_count = 0, drvr_optindex = 0, probeindex;
> +	int drvr_optindex = 0, probeindex;
>   	struct blogic_adapter *adapter;
>   	int ret = 0;
>   
> @@ -2368,10 +2368,8 @@ static int __init blogic_init(void)
>   					list_del(&myadapter->host_list);
>   					scsi_host_put(host);
>   					ret = -ENODEV;
> -				} else {
> +				} else
>   					scsi_scan_host(host);
> -					adapter_count++;
> -				}
>   			}
>   		} else {
>   			/*