linux-kernel - Re: [PATCH v3] soc: ti: Convert allocations to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7h8rkw2bqp.fsf@baylibre.com>
Date:   Mon, 31 Oct 2022 09:34:22 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Nishanth Menon <nm@...com>, Nicolas Frayer <nfrayer@...libre.com>
Cc:     ssantosh@...nel.org, linux-kernel@...r.kernel.org,
        glaroque@...libre.com
Subject: Re: [PATCH v3] soc: ti: Convert allocations to devm

Nishanth Menon <nm@...com> writes:

> On 20:00-20221028, Nicolas Frayer wrote:
>
> Quick cosmetics:
> linux-arm-kernel@...ts.infradead.org (moderated list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS)
> is part of the results of get_maintainers.pl  why drop not CC it?
>
>  git log --oneline drivers/soc/ti/k3-socinfo.c
> soc: ti: k3-socinfo:
>
> Please fix the $subject
>
>> Changed the memory and resource allocations in the probe function
>> to devm. Also added a remove callback.
>
> Yes, but why are we doing this change, what benefit do we get by doing
> this change?
>
>
>> 
>> Signed-off-by: Nicolas Frayer <nfrayer@...libre.com>
>> ---
>> 
>> v2->v3:
>> dropped module conversion part of this series while other driver dependencies
>> on socinfo are worked out.
>> A dependency issue is introduced by changing subsys_initcall()
>> to module_platform_driver(). Some drivers using the socinfo information probe
>> before the socinfo driver itself and it makes their probe fail.
>> 
>> Dropped series:
>> https://lore.kernel.org/all/20221010131538.7333-1-nfrayer@baylibre.com/
>
> OK - if we are'nt going to convert this into modules, then is there a
> reason for this patch?

Yeah, Nishanth has a good point here.  Lets wait on this patch an
included it with the module conversion once we figure out the deferred
probe issues around this.

Kevin