linux-kernel - Re: [PATCH cgroup/for-6.1-fixes] cgroup: Implement DEBUG_CGROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1/+3I2mJ+uAlAYc@cmpxchg.org>
Date:   Mon, 31 Oct 2022 12:59:08 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     Zefan Li <lizefan.x@...edance.com>, kernel-team@...a.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH cgroup/for-6.1-fixes] cgroup: Implement DEBUG_CGROUP_REF

On Fri, Oct 28, 2022 at 10:35:28AM -1000, Tejun Heo wrote:
> It's really difficult to debug when cgroup or css refs leak. Let's add a
> debug option to force the refcnt function to not be inlined so that they can
> be kprobed for debugging.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
> Applying this to for-6.1-fixes. Holler for any objections.

The out-of-line versions need EXPORT_SYMBOL as they're used by modules
(loop e.g.). Otherwise it looks good to me.