linux-kernel - Re: [PATCH 1/2] slimbus: qcom-ngd-ctrl: check for device runtime PM status during ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e3bd948-6649-742b-ea4c-4f7236d156a5@linaro.org>
Date:   Mon, 31 Oct 2022 18:29:06 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Cc:     Chandana Kishori Chiluveru <cchiluve@...eaurora.org>
Subject: Re: [PATCH 1/2] slimbus: qcom-ngd-ctrl: check for device runtime PM
 status during ISR



On 28/09/2022 14:20, Krzysztof Kozlowski wrote:
> Slimbus core interrupt is getting fired after suspend. At this point
> ADSP slimbus hardware is off with gated clocks which is leading to an
> unclocked access when HLOS slimbus tried to read the interrupt
> status register in the ISR.
> 
> Co-developed-by: Chandana Kishori Chiluveru <cchiluve@...eaurora.org>
> Signed-off-by: Chandana Kishori Chiluveru <cchiluve@...eaurora.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Applied both,

--srini
>   drivers/slimbus/qcom-ngd-ctrl.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
> index cec11aa106bf..ba36eb5c0de3 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -763,7 +763,14 @@ static irqreturn_t qcom_slim_ngd_interrupt(int irq, void *d)
>   {
>   	struct qcom_slim_ngd_ctrl *ctrl = d;
>   	void __iomem *base = ctrl->ngd->base;
> -	u32 stat = readl(base + NGD_INT_STAT);
> +	u32 stat;
> +
> +	if (pm_runtime_suspended(ctrl->ctrl.dev)) {
> +		dev_warn_once(ctrl->dev, "Interrupt received while suspended\n");
> +		return IRQ_NONE;
> +	}
> +
> +	stat = readl(base + NGD_INT_STAT);
>   
>   	if ((stat & NGD_INT_MSG_BUF_CONTE) ||
>   		(stat & NGD_INT_MSG_TX_INVAL) || (stat & NGD_INT_DEV_ERR) ||