linux-kernel - Re: [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get pages from an iteraor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61e7810f-97e2-1185-312a-d096b5b2bced@nvidia.com>
Date:   Mon, 31 Oct 2022 13:46:07 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Matthew Wilcox <willy@...radead.org>,
        David Howells <dhowells@...hat.com>
CC:     <viro@...iv.linux.org.uk>, <linux-mm@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, Christoph Hellwig <hch@....de>,
        <smfrench@...il.com>, <torvalds@...ux-foundation.org>,
        <linux-cifs@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get
 pages from an iteraor

On 10/31/22 07:52, Matthew Wilcox wrote:
> On Mon, Oct 31, 2022 at 02:49:32PM +0000, David Howells wrote:
>> I added a macro by which you can query an iterator to find out how the
>> extraction function will treat the pages (it returns 0, FOLL_GET or FOLL_PIN
>> as appropriate).  Note that it's a macro to avoid #inclusion of linux/mm.h in
>> linux/uio.h.
> 
> I'd support moving FOLL_* definitions to mm_types.h along with
> FAULT_FLAG_* and VM_FAULT_*.

+1, great idea. The use of FOLL_* without including it's .h directly was
the first thing that jumped out at me when I just started looking at
this. And these really are mm types, so yes.

thanks,
-- 
John Hubbard
NVIDIA