linux-kernel - Re: [PATCH] ath11k (gcc13): synchronize ath11k_mac_he_gi_to_nl80211_he

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1041acdb-2978-7413-5567-ae9c14471605@infradead.org>
Date:   Tue, 1 Nov 2022 10:54:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        linux-kernel@...r.kernel.org, Martin Liska <mliska@...e.cz>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, ath11k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ath11k (gcc13): synchronize
 ath11k_mac_he_gi_to_nl80211_he_gi()'s return type

Hi--

On 11/1/22 10:19, Kalle Valo wrote:
> Randy Dunlap <rdunlap@...radead.org> writes:
> 
>> On 11/1/22 01:45, Kalle Valo wrote:
>>> Jiri Slaby <jirislaby@...nel.org> writes:
>>>
>>>> On 31. 10. 22, 22:16, Jeff Johnson wrote:
>>>>
>>>>> On 10/31/2022 4:43 AM, Jiri Slaby (SUSE) wrote:
>>
>>>>> Suggest the subject should be
>>>>> wifi: ath11k: synchronize ath11k_mac_he_gi_to_nl80211_he_gi()'s return type
>>>>
>>>> FWIW I copied from:
>>>> $ git log --format=%s  drivers/net/wireless/ath/ath11k/mac.h
>>>> ath11k: Handle keepalive during WoWLAN suspend and resume
>>>> ath11k: reduce the wait time of 11d scan and hw scan while add interface
>>>> ath11k: Add basic WoW functionalities
>>>> ath11k: add support for hardware rfkill for QCA6390
>>>> ath11k: report tx bitrate for iw wlan station dump
>>>> ath11k: add 11d scan offload support
>>>> ath11k: fix read fail for htt_stats and htt_peer_stats for single pdev
>>>> ath11k: add support for BSS color change
>>>> ath11k: add support for 80P80 and 160 MHz bandwidth
>>>> ath11k: Add support for STA to handle beacon miss
>>>> ath11k: add support to configure spatial reuse parameter set
>>>> ath11k: remove "ath11k_mac_get_ar_vdev_stop_status" references
>>>> ath11k: Perform per-msdu rx processing
>>>> ath11k: fix incorrect peer stats counters update
>>>> ath11k: Move mac80211 hw allocation before wmi_init command
>>>> ath11k: fix missed bw conversion in tx completion
>>>> ath11k: driver for Qualcomm IEEE 802.11ax devices
>>>
>>> Yeah, using "wifi:" is a new prefix we started using with wireless
>>> patches this year.
>>>
>>
>> It would be nice if that was documented somewhere...
> 
> It is mentioned on our wiki but I doubt anyone reads it :)

I think that you are correct. ;)

> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject
> 
> Do let me know if there are other places which should have this info.

Ideally it would be in the subsystem's profile document as described in the
MAINTAINERS file:

	P: Subsystem Profile document for more details submitting
	   patches to the given subsystem. This is either an in-tree file,
	   or a URI. See Documentation/maintainer/maintainer-entry-profile.rst
	   for details.

although that seems to be overkill IMHO just to add a prefix: setting.

You could just clone some other maintainer's Profile document and then modify it
to anything that you would like to have in it as far as Maintaining and patching
are concerned.

> I did assume it will take at least a year or two before people get used
> to the new prefix, but my patchwork script has a check for this and it's
> trivial to fix the subject before I commit the patch. So hopefully the
> switch goes smoothly.

OK.

Thanks.

-- 
~Randy