linux-kernel - Re: [PATCH v3 17/17] ufs: qcom-host: Enable multi circular queue capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221101184718.GG9077@asutoshd-linux1.qualcomm.com>
Date:   Tue, 1 Nov 2022 11:47:19 -0700
From:   Asutosh Das <quic_asutoshd@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>
CC:     <quic_cang@...cinc.com>, <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>, <quic_nguyenb@...cinc.com>,
        <quic_xiaosenh@...cinc.com>, <stanley.chu@...iatek.com>,
        <eddie.huang@...iatek.com>, <daejun7.park@...sung.com>,
        <avri.altman@....com>, <mani@...nel.org>, <beanhuo@...ron.com>,
        <quic_richardp@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 17/17] ufs: qcom-host: Enable multi circular queue
 capability

On Fri, Oct 28 2022 at 15:08 -0700, Bart Van Assche wrote:
>On 10/20/22 11:03, Asutosh Das wrote:
>>diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>>index 36c40210..b740299 100644
>>--- a/drivers/ufs/host/ufs-qcom.c
>>+++ b/drivers/ufs/host/ufs-qcom.c
>>@@ -853,6 +853,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba)
>>  	hba->caps |= UFSHCD_CAP_CRYPTO;
>>  	hba->caps |= UFSHCD_CAP_AGGR_POWER_COLLAPSE;
>>  	hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND;
>>+	hba->caps |= UFSHCD_CAP_MCQ_EN;
>
>Shouldn't we have a flag that disables MCQ rather than a flag that 
>enables MCQ? Otherwise the above line will be duplicated in every 
>single host controller driver that supports MCQ.
>
Thanks, that makes sense.
I will drop this change and add a cap to disable MCQ via module parameter.

>Thanks,
>
>Bart.

-asd