linux-kernel - Re: [PATCH net-next] netconsole: Enable live renaming for network interfaces used by netconsole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2F7x319oanq/+i1@lunn.ch>
Date:   Tue, 1 Nov 2022 21:04:23 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Andy Ren <andy.ren@...cruise.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.com, kuba@...nel.org,
        pabeni@...hat.com, corbet@....net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, roman.gushchin@...ux.dev
Subject: Re: [PATCH net-next] netconsole: Enable live renaming for network
 interfaces used by netconsole

>     where
>  	+             if present, enable extended console support
>  	src-port      source for UDP packets (defaults to 6665)
>  	src-ip        source IP to use (interface address)
>  	dev           network interface (eth0)
> +	*             if present, allow runtime network interface renaming
>  	tgt-port      port for logging agent (6666)
>  	tgt-ip        IP address for logging agent
>  	tgt-macaddr   ethernet MAC address for logging agent (broadcast)
>  
>  Examples::
>  
> - linux netconsole=4444@...0.0.1/eth1,9353@...0.0.2/12:34:56:78:9a:bc
> + linux netconsole=4444@...0.0.1/eth1*,9353@...0.0.2/12:34:56:78:9a:bc

To me, this looks like a wildcard of the interface name.

Maybe move the position of the *. Put it after the + ?

      Andrew