linux-kernel - Re: [PATCH v1 2/3] pwm: core: Drop unneeded casting in pwm_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211020413.cGq4Wipz-lkp@intel.com>
Date:   Wed, 2 Nov 2022 04:53:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Thierry Reding <thierry.reding@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 2/3] pwm: core: Drop unneeded casting in pwm_seq_show()

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on thierry-reding-pwm/for-next]
[also build test WARNING on linus/master v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pwm-core-Refactor-pwmchip_add-to-avoid-extra-checks/20221102-014412
base:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-next
patch link:    https://lore.kernel.org/r/20221101174255.54452-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 2/3] pwm: core: Drop unneeded casting in pwm_seq_show()
config: i386-randconfig-a013
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5e2a7f06a8d355d7dcc059703bb5990ae6358fef
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/pwm-core-Refactor-pwmchip_add-to-avoid-extra-checks/20221102-014412
        git checkout 5e2a7f06a8d355d7dcc059703bb5990ae6358fef
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pwm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/pwm/core.c:1192:46: warning: format specifies type 'char *' but the argument has type 'void *' [-Wformat]
           seq_printf(s, "%s%s/%s, %d PWM device%s\n", s->private,
                          ~~                           ^~~~~~~~~~
   1 warning generated.


vim +1192 drivers/pwm/core.c

  1187	
  1188	static int pwm_seq_show(struct seq_file *s, void *v)
  1189	{
  1190		struct pwm_chip *chip = list_entry(v, struct pwm_chip, list);
  1191	
> 1192		seq_printf(s, "%s%s/%s, %d PWM device%s\n", s->private,
  1193			   chip->dev->bus ? chip->dev->bus->name : "no-bus",
  1194			   dev_name(chip->dev), chip->npwm,
  1195			   (chip->npwm != 1) ? "s" : "");
  1196	
  1197		pwm_dbg_show(chip, s);
  1198	
  1199		return 0;
  1200	}
  1201	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (153478 bytes)