linux-kernel - Re: [PATCH 1/1] smack_lsm: remove unnecessary type casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4929fc7f-eb31-6ee4-0365-1b0f61ad5946@schaufler-ca.com>
Date:   Tue, 1 Nov 2022 14:12:56 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     XU pengfei <xupengfei@...china.com>, paul@...l-moore.com,
        jmorris@...ei.org, serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, casey@...aufler-ca.com
Subject: Re: [PATCH 1/1] smack_lsm: remove unnecessary type casting

On 10/26/2022 1:29 AM, XU pengfei wrote:
> Remove unnecessary type casting.
> The type of inode variable is struct inode *, so no type casting required.
>
> Signed-off-by: XU pengfei <xupengfei@...china.com>

Thank you. Added to smack-next:
	https://github.com/cschaufler/smack-next.git#next

> ---
>  security/smack/smack_lsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index b6306d71c908..853c6878edc0 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -1409,7 +1409,7 @@ static int smack_inode_getsecurity(struct user_namespace *mnt_userns,
>  	struct socket_smack *ssp;
>  	struct socket *sock;
>  	struct super_block *sbp;
> -	struct inode *ip = (struct inode *)inode;
> +	struct inode *ip = inode;
>  	struct smack_known *isp;
>  
>  	if (strcmp(name, XATTR_SMACK_SUFFIX) == 0)