linux-kernel - RE: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52761247732AC600BB390C578C369@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Tue, 1 Nov 2022 09:10:47 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Eric Farman <farman@...ux.ibm.com>,
        Matthew Rosato <mjrosato@...ux.ibm.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        "Liu, Yi L" <yi.l.liu@...el.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kirti Wankhede <kwankhede@...dia.com>,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Diana Craciun <diana.craciun@....nxp.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        David Airlie <airlied@...il.com>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        Halil Pasic <pasic@...ux.ibm.com>,
        "Christian Borntraeger" <borntraeger@...ux.ibm.com>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "Wang, Zhi A" <zhi.a.wang@...el.com>,
        Jason Herne <jjherne@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Eric Auger <eric.auger@...hat.com>,
        "Harald Freudenberger" <freude@...ux.ibm.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "intel-gvt-dev@...ts.freedesktop.org" 
        <intel-gvt-dev@...ts.freedesktop.org>,
        Tony Krowiak <akrowiak@...ux.ibm.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        Yishai Hadas <yishaih@...dia.com>,
        "Peter Oberparleiter" <oberpar@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Abhishek Sahu <abhsahu@...dia.com>
Subject: RE: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

> From: Eric Farman
> Sent: Thursday, October 20, 2022 12:22 AM
> 
> Now that we have a reasonable separation of structs that follow
> the subchannel and mdev lifecycles, there's no reason we can't
> call the official vfio_alloc_device routine for our private data,
> and behave like everyone else.
> 
> Signed-off-by: Eric Farman <farman@...ux.ibm.com>

This looks good to me. With Jason's suggestion handled,

Reviewed-by: Kevin Tian <kevin.tian@...el.com>