linux-kernel - Re: wifi: airo: do not assign -1 to unsigned char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <166729412401.15005.1682705386476857844.kvalo@kernel.org>
Date:   Tue,  1 Nov 2022 09:15:26 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-wireless@...r.kernel.org
Subject: Re: wifi: airo: do not assign -1 to unsigned char

"Jason A. Donenfeld" <Jason@...c4.com> wrote:

> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, we get a warning when assigning the
> unchecked output of hex_to_bin() to that unsigned char. Mark `key` as a
> `u8`, which matches the struct's type, and then check each call to
> hex_to_bin() before casting.
> 
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Patch applied to wireless.git, thanks.

e6cb8769452e wifi: airo: do not assign -1 to unsigned char

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221024162843.535921-1-Jason@zx2c4.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches