linux-kernel - Re: [PATCH 4/4] ufs: core: Remove ufshcd_map_desc_id_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 09:51:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Arthur Simchaev <Arthur.Simchaev@....com>,
        martin.petersen@...cle.com
Cc:     oe-kbuild-all@...ts.linux.dev, avri.altman@....com,
        Avi.Shchislowski@....com, beanhuo@...ron.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        Arthur Simchaev <Arthur.Simchaev@....com>
Subject: Re: [PATCH 4/4] ufs: core: Remove ufshcd_map_desc_id_to_length
 function

Hi Arthur,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on next-20221031]
[cannot apply to jejb-scsi/for-next linus/master v6.1-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arthur-Simchaev/ufs-core-Always-read-the-descriptors-with-max-length/20221101-002915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/1667233524-13715-5-git-send-email-Arthur.Simchaev%40wdc.com
patch subject: [PATCH 4/4] ufs: core: Remove ufshcd_map_desc_id_to_length function
config: loongarch-allyesconfig
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5a36737b2cacf2691afb72cdff7ea06d2de0eaa9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Arthur-Simchaev/ufs-core-Always-read-the-descriptors-with-max-length/20221101-002915
        git checkout 5a36737b2cacf2691afb72cdff7ea06d2de0eaa9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/ufs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/ufs/ufshcd.h:22,
                    from drivers/ufs/core/ufshcd-priv.h:7,
                    from drivers/ufs/core/ufshpb.c:18:
   drivers/ufs/core/ufshpb.c: In function 'ufshpb_get_lu_info':
>> include/ufs/ufs.h:19:35: warning: passing argument 7 of 'ufshcd_query_descriptor_retry' makes pointer from integer without a cast [-Wint-conversion]
      19 | #define QUERY_DESC_MAX_SIZE       255
         |                                   ^~~
         |                                   |
         |                                   int
   drivers/ufs/core/ufshpb.c:2391:55: note: in expansion of macro 'QUERY_DESC_MAX_SIZE'
    2391 |                                             desc_buf, QUERY_DESC_MAX_SIZE);
         |                                                       ^~~~~~~~~~~~~~~~~~~
   drivers/ufs/core/ufshcd-priv.h:49:54: note: expected 'int *' but argument is of type 'int'
      49 |                                   u8 *desc_buf, int *buf_len);
         |                                                 ~~~~~^~~~~~~


vim +/ufshcd_query_descriptor_retry +19 include/ufs/ufs.h

5a0b0cb9bee767 drivers/scsi/ufs/ufs.h Sujit Reddy Thumma 2013-07-30  17  
220d17a69de432 drivers/scsi/ufs/ufs.h Avri Altman        2018-10-07  18  #define GENERAL_UPIU_REQUEST_SIZE (sizeof(struct utp_upiu_req))
d44a5f98bb49b2 drivers/scsi/ufs/ufs.h Dolev Raviv        2014-06-29 @19  #define QUERY_DESC_MAX_SIZE       255
d44a5f98bb49b2 drivers/scsi/ufs/ufs.h Dolev Raviv        2014-06-29  20  #define QUERY_DESC_MIN_SIZE       2
b573d484e4ff33 drivers/scsi/ufs/ufs.h Yaniv Gardi        2016-03-10  21  #define QUERY_DESC_HDR_SIZE       2
68078d5cc1a59b drivers/scsi/ufs/ufs.h Dolev Raviv        2013-07-30  22  #define QUERY_OSF_SIZE            (GENERAL_UPIU_REQUEST_SIZE - \
68078d5cc1a59b drivers/scsi/ufs/ufs.h Dolev Raviv        2013-07-30  23  					(sizeof(struct utp_upiu_header)))
09a5a24ff36f90 drivers/scsi/ufs/ufs.h Avri Altman        2018-11-22  24  #define UFS_SENSE_SIZE	18
7a3e97b0dc4bba drivers/scsi/ufs/ufs.h Santosh Yaraganavi 2012-02-29  25  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (327684 bytes)