linux-kernel - Re: [PATCH] memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2EIblbX0eDgpJ35@orome>
Date:   Tue, 1 Nov 2022 12:52:14 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Bo Liu <liubo03@...pur.com>
Cc:     krzysztof.kozlowski@...aro.org, jonathanh@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE
 with DEFINE_DEBUGFS_ATTRIBUTE

On Tue, Nov 01, 2022 at 04:16:11AM -0400, Bo Liu wrote:
> Fix the following coccicheck warning:
>  drivers/memory/tegra/tegra20-emc.c:902:0-23: WARNING:
>   tegra_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>  drivers/memory/tegra/tegra20-emc.c:872:0-23: WARNING:
>   tegra_emc_debug_min_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>  drivers/memory/tegra/tegra20-emc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This seems incomplete: the rationale in that debugfs cocci script says
that DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe() is the
pattern to use vs. the less efficient DEFINE_SIMPLE_ATTRIBUTE +
debugfs_create_file(). So this patch should probably use the unsafe
function variant at the same time to take full advantage.

Thierry

> 
> diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
> index bd4e37b6552d..c2b4caccfae9 100644
> --- a/drivers/memory/tegra/tegra20-emc.c
> +++ b/drivers/memory/tegra/tegra20-emc.c
> @@ -869,7 +869,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
>  			tegra_emc_debug_min_rate_get,
>  			tegra_emc_debug_min_rate_set, "%llu\n");
>  
> @@ -899,7 +899,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
>  			tegra_emc_debug_max_rate_get,
>  			tegra_emc_debug_max_rate_set, "%llu\n");
>  
> -- 
> 2.27.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)