linux-kernel - Re: [PATCH 2/3] pwm: Add Aspeed ast2600 PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 19:57:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Billy Tsai <billy_tsai@...eedtech.com>, jdelvare@...e.com,
        linux@...ck-us.net, robh+dt@...nel.org, joel@....id.au,
        andrew@...id.au, lee.jones@...aro.org, thierry.reding@...il.com,
        u.kleine-koenig@...gutronix.de, p.zabel@...gutronix.de,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-pwm@...r.kernel.org, BMC-SW@...eedtech.com,
        garnermic@...a.com
Cc:     oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 2/3] pwm: Add Aspeed ast2600 PWM support

Hi Billy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on thierry-reding-pwm/for-next lee-mfd/for-mfd-next robh/for-next linus/master v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Billy-Tsai/Support-pwm-tach-driver-for-aspeed-ast26xx/20221031-183813
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20221031103809.20225-3-billy_tsai%40aspeedtech.com
patch subject: [PATCH 2/3] pwm: Add Aspeed ast2600 PWM support
config: arm64-randconfig-s053-20221101
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/1e73d9a570e9276911d41cce20e4dcdb0bcdc4d6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Billy-Tsai/Support-pwm-tach-driver-for-aspeed-ast26xx/20221031-183813
        git checkout 1e73d9a570e9276911d41cce20e4dcdb0bcdc4d6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/perf/ drivers/pwm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/pwm/pwm-aspeed-ast2600.c:255:52: sparse: sparse: Using plain integer as NULL pointer

vim +255 drivers/pwm/pwm-aspeed-ast2600.c

   231	
   232	static int aspeed_pwm_probe(struct platform_device *pdev)
   233	{
   234		struct device *dev = &pdev->dev;
   235		int ret;
   236		struct aspeed_pwm_data *priv;
   237		struct device_node *np;
   238		struct platform_device *parent_dev;
   239	
   240		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
   241		if (!priv)
   242			return -ENOMEM;
   243	
   244		np = pdev->dev.parent->of_node;
   245		if (!of_device_is_compatible(np, "aspeed,ast2600-pwm-tach"))
   246			return dev_err_probe(dev, -ENODEV,
   247					     "Unsupported pwm device binding\n");
   248	
   249		priv->regmap = syscon_node_to_regmap(np);
   250		if (IS_ERR(priv->regmap))
   251			return dev_err_probe(dev, PTR_ERR(priv->regmap),
   252					     "Couldn't get regmap\n");
   253	
   254		parent_dev = of_find_device_by_node(np);
 > 255		priv->clk = devm_clk_get(&parent_dev->dev, 0);
   256		if (IS_ERR(priv->clk))
   257			return dev_err_probe(dev, PTR_ERR(priv->clk),
   258					     "Couldn't get clock\n");
   259	
   260		priv->reset = devm_reset_control_get_shared(&parent_dev->dev, NULL);
   261		if (IS_ERR(priv->reset))
   262			return dev_err_probe(dev, PTR_ERR(priv->reset),
   263					     "Couldn't get reset control\n");
   264	
   265		ret = clk_prepare_enable(priv->clk);
   266		if (ret)
   267			return dev_err_probe(dev, ret, "Couldn't enable clock\n");
   268	
   269		ret = reset_control_deassert(priv->reset);
   270		if (ret) {
   271			dev_err_probe(dev, ret, "Couldn't deassert reset control\n");
   272			goto err_disable_clk;
   273		}
   274	
   275		priv->chip.dev = dev;
   276		priv->chip.ops = &aspeed_pwm_ops;
   277		priv->chip.npwm = PWM_ASPEED_NR_PWMS;
   278	
   279		ret = pwmchip_add(&priv->chip);
   280		if (ret < 0) {
   281			dev_err_probe(dev, ret, "Failed to add PWM chip\n");
   282			goto err_assert_reset;
   283		}
   284		dev_set_drvdata(dev, priv);
   285		return 0;
   286	err_assert_reset:
   287		reset_control_assert(priv->reset);
   288	err_disable_clk:
   289		clk_disable_unprepare(priv->clk);
   290		return ret;
   291	}
   292	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (165798 bytes)