linux-kernel - Re: [PATCH v3] kprobes,lib: kretprobe scalability improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 20:27:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     wuqiang <wuqiang.matt@...edance.com>, mhiramat@...nel.org,
        davem@...emloft.net, anil.s.keshavamurthy@...el.com,
        naveen.n.rao@...ux.ibm.com, rostedt@...dmis.org, ast@...nel.org,
        akpm@...ux-foundation.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        mattwu@....com, wuqiang <wuqiang.matt@...edance.com>
Subject: Re: [PATCH v3] kprobes,lib: kretprobe scalability improvement

Hi wuqiang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/wuqiang/kprobes-lib-kretprobe-scalability-improvement/20221101-110242
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20221101014346.150812-1-wuqiang.matt%40bytedance.com
patch subject: [PATCH v3] kprobes,lib: kretprobe scalability improvement
config: x86_64-rhel-8.3-kselftests
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/a0deeba1c316e59b94856c8eda40f6680fd511f8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review wuqiang/kprobes-lib-kretprobe-scalability-improvement/20221101-110242
        git checkout a0deeba1c316e59b94856c8eda40f6680fd511f8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/trace/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   kernel/trace/fprobe.c: In function 'fprobe_init_rethook':
>> kernel/trace/fprobe.c:128:13: warning: unused variable 'i' [-Wunused-variable]
     128 |         int i, size;
         |             ^


vim +/i +128 kernel/trace/fprobe.c

cad9931f64dc7f Masami Hiramatsu 2022-03-15  125  
5b0ab78998e325 Masami Hiramatsu 2022-03-15  126  static int fprobe_init_rethook(struct fprobe *fp, int num)
5b0ab78998e325 Masami Hiramatsu 2022-03-15  127  {
5b0ab78998e325 Masami Hiramatsu 2022-03-15 @128  	int i, size;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  129  
5b0ab78998e325 Masami Hiramatsu 2022-03-15  130  	if (num < 0)
5b0ab78998e325 Masami Hiramatsu 2022-03-15  131  		return -EINVAL;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  132  
5b0ab78998e325 Masami Hiramatsu 2022-03-15  133  	if (!fp->exit_handler) {
5b0ab78998e325 Masami Hiramatsu 2022-03-15  134  		fp->rethook = NULL;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  135  		return 0;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  136  	}
5b0ab78998e325 Masami Hiramatsu 2022-03-15  137  
5b0ab78998e325 Masami Hiramatsu 2022-03-15  138  	/* Initialize rethook if needed */
5b0ab78998e325 Masami Hiramatsu 2022-03-15  139  	size = num * num_possible_cpus() * 2;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  140  	if (size < 0)
5b0ab78998e325 Masami Hiramatsu 2022-03-15  141  		return -E2BIG;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  142  
a0deeba1c316e5 wuqiang          2022-11-01  143  	fp->rethook = rethook_alloc((void *)fp, fprobe_exit_handler, GFP_KERNEL,
a0deeba1c316e5 wuqiang          2022-11-01  144  				sizeof(struct fprobe_rethook_node), size);
a0deeba1c316e5 wuqiang          2022-11-01  145  	if (!fp->rethook)
5b0ab78998e325 Masami Hiramatsu 2022-03-15  146  		return -ENOMEM;
a0deeba1c316e5 wuqiang          2022-11-01  147  
5b0ab78998e325 Masami Hiramatsu 2022-03-15  148  	return 0;
5b0ab78998e325 Masami Hiramatsu 2022-03-15  149  }
5b0ab78998e325 Masami Hiramatsu 2022-03-15  150  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (172576 bytes)