linux-kernel - Re: [PATCH net-next v2 2/2] net: hinic: Add control command support for VF PMD driver in DPDK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a65a97fw.fsf@intel.com>
Date:   Tue, 01 Nov 2022 14:37:39 +0200
From:   Jani Nikula <jani.nikula@...el.com>
To:     Cai Huoqing <cai.huoqing@...ux.dev>
Cc:     kuba@...nel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Zhengchao Shao <shaozhengchao@...wei.com>,
        SeongJae Park <sj@...nel.org>,
        Bin Chen <bin.chen@...igine.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: hinic: Add control command support
 for VF PMD driver in DPDK

On Tue, 01 Nov 2022, Cai Huoqing <cai.huoqing@...ux.dev> wrote:
> On 01 11月 22 12:46:32, Jani Nikula wrote:
>> On Tue, 01 Nov 2022, Cai Huoqing <cai.huoqing@...ux.dev> wrote:
>> > HINIC has a mailbox for PF-VF communication and the VF driver
>> > could send port control command to PF driver via mailbox.
>> >
>> > The control command only can be set to register in PF,
>> > so add support in PF driver for VF PMD driver control
>> > command when VF PMD driver work with linux PF driver.
>> >
>> > Then there is no need to add handlers to nic_vf_cmd_msg_handler[],
>> > because the host driver just forwards it to the firmware.
>> > Actually the firmware works on a coprocessor MGMT_CPU(inside the NIC)
>> > which will recv and deal with these commands.
>> >
>> > Signed-off-by: Cai Huoqing <cai.huoqing@...ux.dev>
>> 
>> Out of curiosity, what exactly compelled you to Cc me on this particular
>> patch? I mean there aren't a whole lot of places in the kernel that
>> would be more off-topic for me. :)
> run ./scripts/get_maintainer.pl this patch in net-next
> then get your email
> Jani Nikula <jani.nikula@...el.com> (commit_signer:1/8=12%)
> Maybe you have some commits in net subsystem ?

A grand total of 3 commits in drivers/net/wireless/ath/ two years ago,
adding 3 const keywords, nowhere near of what you're changing.

get_maintainer.pl is utterly broken to suggest I should be Cc'd.


BR,
Jani.


>> 
>> BR,
>> Jani.
>> 
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center

-- 
Jani Nikula, Intel Open Source Graphics Center