linux-kernel - Re: [PATCH v3] i2c/pasemi: PASemi I2C controller IRQ enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2EWvokvkixLucg+@shikoro>
Date:   Tue, 1 Nov 2022 13:53:18 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Sven Peter <sven@...npeter.dev>
Cc:     Arminder Singh <arminders208@...look.com>,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, asahi@...ts.linux.dev,
        linuxppc-dev@...ts.ozlabs.org,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Hector Martin <marcan@...can.st>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Nicholas Piggin <npiggin@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH v3] i2c/pasemi: PASemi I2C controller IRQ enablement


> > +    complete(&smbus->irq_completion);
> 
> I only realized just now that you also want to disable the interrupt
> right here by writing to IMASK. This is a level sensitive interrupt at
> AIC level so the moment this handler returns it will fire again until
> you reach the write above after the completion wait a bit later.

This seems like a valid request. Any chance for a v4? We are so close to
being good here...


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)