linux-kernel - Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 14:43:27 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     cuigaosheng <cuigaosheng1@...wei.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        puwen@...on.cn, TonyWWang-oc@...oxin.com, peterz@...radead.org,
        gregkh@...uxfoundation.org, andrew.cooper3@...rix.com,
        tony.luck@...el.com, mario.limonciello@....com,
        pawan.kumar.gupta@...ux.intel.com, chenyi.qiang@...el.com,
        rdunlap@...radead.org, jithu.joseph@...el.com,
        rafael.j.wysocki@...el.com, paulmck@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)

On Tue, Nov 1, 2022 at 2:37 PM cuigaosheng <cuigaosheng1@...wei.com> wrote:
> > 215 [ 0.953146][ T0] UBSAN: shift-out-of-bounds in mm/shmem.c:3749:18
> > 216 [ 0.953863][ T0] left shift of 1 by 31 places cannot be represented in type 'int'

Isn't this just an issue with `1 << 31` needing to be `1U << 31`?

Jason