linux-kernel - Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y2EttkwUvMReQcqg@sirena.org.uk>
Date:   Tue, 1 Nov 2022 14:31:18 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Venkata Prasad Potturu <venkataprasad.potturu@....com>
Cc:     Venkata Prasad Potturu 
        <venkataprasad.potturu@....corp-partner.google.com>,
        alsa-devel@...a-project.org, vsujithkumar.reddy@....com,
        Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, ssabakar@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in
 machine driver

On Tue, Nov 01, 2022 at 03:15:08PM +0530, Venkata Prasad Potturu wrote:

> On 10/28/22 16:28, Mark Brown wrote:
> > > +static int tdm_mode = 0;
> > > +module_param_named(tdm_mode, tdm_mode, int, 0444);
> > > +MODULE_PARM_DESC(tdm_mode, "Set 1 for tdm mode, set 0 for i2s mode");
> > Why is this a module parameter - how would a user decide to set this?
> > Is it something that someone might want to change at runtime?
> 
> While inserting this module we need to pass tdm_mode variable as 0 or 1 like
> below.

> sudo insmod /lib/modules/$(uname
> -r)/kernel/sound/soc/amd/acp/snd-acp-mach.ko *tdm_mode=1*

Right, that's what the code does but why is this something that should
be controlled in this fashion?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)