linux-kernel - Re: [PATCH v2 1/2] change the function name s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHJEyKXhEGnFRfdv5xSQeEp4bTS4FsvU9oU=hfeuUdYVaovWHQ@mail.gmail.com>
Date:   Tue, 1 Nov 2022 15:55:54 +0100
From:   Tanju Brunostar <tanjubrunostar0@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH v2 1/2] change the function name s_vFillRTSHead

On Tue, Nov 1, 2022 at 2:32 PM Joe Perches <joe@...ches.com> wrote:
>
> On Tue, 2022-11-01 at 12:37 +0000, Tanjuate Brunostar wrote:
> > Remove the use of Hungarian notation, which is not used in the Linux
> > kernel. Reported by checkpatch
> []
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> []
> > @@ -23,7 +23,7 @@
> >   *      s_uGetTxRsvTime- get frame reserved time
> >   *      s_vFillCTSHead- fulfill CTS ctl header
> >   *      s_vFillFragParameter- Set fragment ctl parameter.
> > - *      s_vFillRTSHead- fulfill RTS ctl header
> > + *      fill_rts_head- fulfill RTS ctl header
>
> Perhaps use header as head is conventionally used in lists.
>
>         fill_rts_header
>
OK, thanks