[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221101151233.gsmmdbz7htkzpbps@halaney-x13s>
Date: Tue, 1 Nov 2022 10:12:33 -0500
From: Andrew Halaney <ahalaney@...hat.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: martin.petersen@...cle.com, jejb@...ux.ibm.com,
andersson@...nel.org, vkoul@...nel.org,
krzysztof.kozlowski+dt@...aro.org, konrad.dybcio@...ainline.org,
robh+dt@...nel.org, quic_cang@...cinc.com,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-scsi@...r.kernel.org, dmitry.baryshkov@...aro.org
Subject: Re: [PATCH v2 12/15] scsi: ufs: ufs-qcom: Fix the Qcom register name
for offset 0xD0
On Mon, Oct 31, 2022 at 11:32:14PM +0530, Manivannan Sadhasivam wrote:
> On newer UFS revisions, the register at offset 0xD0 is called,
> REG_UFS_PARAM0. Since the existing register, RETRY_TIMER_REG is not used
> anywhere, it is safe to use the new name.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
> ---
> drivers/ufs/host/ufs-qcom.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h
> index 9d96ac71b27f..7fe928b82753 100644
> --- a/drivers/ufs/host/ufs-qcom.h
> +++ b/drivers/ufs/host/ufs-qcom.h
> @@ -33,7 +33,8 @@ enum {
> REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4,
> REG_UFS_LOCAL_PORT_ID_REG = 0xC8,
> REG_UFS_PA_ERR_CODE = 0xCC,
> - REG_UFS_RETRY_TIMER_REG = 0xD0,
> + /* On older UFS revisions, this register is called "RETRY_TIMER_REG" */
> + REG_UFS_PARAM0 = 0xD0,
> REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8,
> REG_UFS_CFG1 = 0xDC,
> REG_UFS_CFG2 = 0xE0,
> --
> 2.25.1
>
Powered by blists - more mailing lists