linux-kernel - Re: [PATCH] video: fbdev: omapfb: remove redundant variable checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9cca0527-3483-9a4c-6989-39ecd04c35e9@gmx.de>
Date:   Tue, 1 Nov 2022 16:31:43 +0100
From:   Helge Deller <deller@....de>
To:     Colin Ian King <colin.i.king@...il.com>,
        linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: omapfb: remove redundant variable checksum

On 11/1/22 11:29, Colin Ian King wrote:
> Variable checksum is being used to accumulate values however
> it is never read or used afterwards. It is redundant and can
> be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> index cb63bc0e92ca..b33f62c5cb22 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> @@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
>   {
>   	void __iomem *base = core->base;
>   	u8 cur_addr;
> -	char checksum = 0;
>   	const int retries = 1000;
>   	u8 seg_ptr = ext / 2;
>   	u8 edidbase = ((ext % 2) * 0x80);
> @@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
>   		}
>
>   		pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0);
> -		checksum += pedid[cur_addr];
>   	}
>
>   	return 0;