linux-kernel - Re: [PATCH] Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A805401B-39FB-4575-8C2B-CC7343199869@kococonnector.com>
Date:   Tue, 1 Nov 2022 15:47:25 +0000
From:   Oliver Graute <oliver.graute@...oconnector.com>
To:     Bo Liu <liubo03@...pur.com>
CC:     "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "michael@...rulasolutions.com" <michael@...rulasolutions.com>,
        "dario.binacchi@...rulasolutions.com" 
        <dario.binacchi@...rulasolutions.com>,
        "wsa+renesas@...g-engineering.com" <wsa+renesas@...g-engineering.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with
 DEFINE_DEBUGFS_ATTRIBUTE



> Am 01.11.2022 um 09:14 schrieb Bo Liu <liubo03@...pur.com>:
> 
> Fix the following coccicheck warning:
>  drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
>    debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>

Reviewed-by: Oliver Graute <oliver.graute@...oconnector.com>

> ---
> drivers/input/touchscreen/edt-ft5x06.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index 9ac1378610bc..a184425b6985 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode)
> 	return retval;
> };
> 
> -DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
> +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
> 			edt_ft5x06_debugfs_mode_set, "%llu\n");
> 
> static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
> -- 
> 2.27.0
>