linux-kernel - RE: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HE1PR0401MB2331A8A3546988B5BBBE85B888369@HE1PR0401MB2331.eurprd04.prod.outlook.com>
Date:   Tue, 1 Nov 2022 16:08:00 +0000
From:   Frank Li <frank.li@....com>
To:     Manivannan Sadhasivam <mani@...nel.org>
CC:     "allenbh@...il.com" <allenbh@...il.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "dave.jiang@...el.com" <dave.jiang@...el.com>,
        "helgaas@...nel.org" <helgaas@...nel.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        "jdmason@...zu.us" <jdmason@...zu.us>,
        "kw@...ux.com" <kw@...ux.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "ntb@...ts.linux.dev" <ntb@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix
 indentation of the struct epf_ntb_ctrl



> -----Original Message-----
> From: Manivannan Sadhasivam <mani@...nel.org>
> Sent: Tuesday, November 1, 2022 6:56 AM
> To: Frank Li <frank.li@....com>
> Cc: allenbh@...il.com; bhelgaas@...gle.com; dave.jiang@...el.com;
> helgaas@...nel.org; imx@...ts.linux.dev; jdmason@...zu.us;
> kw@...ux.com; linux-kernel@...r.kernel.org; linux-pci@...r.kernel.org;
> lpieralisi@...nel.org; ntb@...ts.linux.dev
> Subject: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix
> indentation of the struct epf_ntb_ctrl
> 
> Caution: EXT Email
> 
> On Fri, Oct 28, 2022 at 11:56:58AM -0400, Frank Li wrote:
> > From: Frank Li <frank.li@....com>
> >
> > Indentation of the struct epf_ntb_ctrl align with other struct
> >
> 
> "Align the indentation of struct epf_ntb_ctrl with other structs in the driver"
> 
> > Signed-off-by: Frank Li <frank.li@....com>
> > ---
> >  drivers/pci/endpoint/functions/pci-epf-vntb.c | 28 +++++++++----------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > index c0115bcb3b5e..1863006cc36c 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > @@ -99,20 +99,20 @@ enum epf_ntb_bar {
> >   *       NTB Driver               NTB Driver
> >   */
> >  struct epf_ntb_ctrl {
> > -     u32     command;
> > -     u32     argument;
> > -     u16     command_status;
> > -     u16     link_status;
> > -     u32     topology;
> > -     u64     addr;
> > -     u64     size;
> > -     u32     num_mws;
> > -     u32     reserved;
> > -     u32     spad_offset;
> > -     u32     spad_count;
> > -     u32     db_entry_size;
> > -     u32     db_data[MAX_DB_COUNT];
> > -     u32     db_offset[MAX_DB_COUNT];
> > +     u32 command;
> > +     u32 argument;
> > +     u16 command_status;
> > +     u16 link_status;
> > +     u32 topology;
> > +     u64 addr;
> > +     u64 size;
> > +     u32 num_mws;
> > +     u32 reserved;
> > +     u32 spad_offset;
> > +     u32 spad_count;
> > +     u32 db_entry_size;
> > +     u32 db_data[MAX_DB_COUNT];
> > +     u32 db_offset[MAX_DB_COUNT];
> 
> General question: Don't we need to take care of endianess here?

[Frank Li] you are right. But it is out of scope of this patch. 
We can add it later.

> 
> Thanks,
> Mani
> 
> >  } __packed;
> >
> >  struct epf_ntb {
> > --
> > 2.34.1
> >
> 
> --
> மணிவண்ணன் சதாசிவம்