linux-kernel - Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM7w-FUTHEAis-F3bDWSsxzQdT-koD-UO54ee9NzbBpKiQhPzQ@mail.gmail.com>
Date:   Tue, 1 Nov 2022 13:24:10 -0400
From:   Sven van Ashbrook <svenva@...omium.org>
To:     "Limonciello, Mario" <mario.limonciello@....com>
Cc:     Rajat Jain <rajatja@...gle.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "rrangel@...omium.org" <rrangel@...omium.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        Rafael J Wysocki <rjw@...ysocki.net>,
        David E Box <david.e.box@...el.com>,
        Mark Gross <markgross@...nel.org>,
        "swboyd@...omium.org" <swboyd@...omium.org>
Subject: Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure
 warn() to WARN()

On Mon, Oct 31, 2022 at 4:55 PM Limonciello, Mario
<mario.limonciello@....com> wrote:
>
> I just spun together an RFC series for this idea and while doing it I
> had the same realization.  So I left the warning messages in place for
> both drivers.
>
> You can take a look at the series here:
>
> https://lore.kernel.org/platform-driver-x86/20221031204320.22464-1-mario.limonciello@amd.com/T/#m6c7db55c98b8a3ce8c48d451fc01c1d9b0df37fb
>

We've had some internal discussions within ChromeOS intel big core,
and we believe this is a worthwhile effort, and we are supportive, as
long as our current S0ix fail detection will not break for the
foreseeable future, i.e. as long as the warning message and register
dump stays in place. Which is the case for your RFC.

+swboyd@...omium.org who expressed interest in doing something similar for ARM.