linux-kernel - Re: [PATCH v5 1/4] ccp: Name -1 return value as SEV_RET_NO_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55c2794b-a8fc-790d-1529-424ae804185e@amd.com>
Date:   Wed, 2 Nov 2022 12:30:17 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Peter Gonda <pgonda@...gle.com>, dionnaglaze@...gle.com,
        linux-kernel@...r.kernel.org, x86@...nel.org
Cc:     jroedel@...e.de, luto@...nel.org, mingo@...hat.com,
        pbonzini@...hat.com
Subject: Re: [PATCH v5 1/4] ccp: Name -1 return value as SEV_RET_NO_FW_CALL

On 11/2/22 10:43, Peter Gonda wrote:
> From: Dionna Glaze <dionnaglaze@...gle.com>
> 
> The PSP can return a "firmware error" code of -1 in circumstances where
> the PSP is not actually called. To make this protocol unambiguous, we
> add a constant naming the return value.
> 
> From: Peter Gonda <pgonda@...gle.com>
> Cc: Thomas Lendacky <Thomas.Lendacky@....com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Joerg Roedel <jroedel@...e.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Andy Lutomirsky <luto@...nel.org>
> 
> Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com>
> 
> I think you can modify the author of this commit to be 'Peter Gonda
> <pgonda@...gle.com>' then include my Signed-off-by.
> 

Since you have to resend for the proper Signed-off-by: chain, the subject 
line should really be: crypto: ccp - Name -1 ...

and you missed copying the other CCP driver maintainer.

It's always good to do a git log on the file(s) you're updating to get an 
idea of the appropriate prefix to use.

Thanks,
Tom

>