linux-kernel - Re: [PATCH v2 0/4] rtc: ingenic: various updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2KreBRUnSVxHfZF@mail.local>
Date:   Wed, 2 Nov 2022 18:40:08 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        od@...ndingux.net
Subject: Re: [PATCH v2 0/4] rtc: ingenic: various updates

On 28/10/2022 23:55:15+0100, Paul Cercueil wrote:
> Hi Alessandro / Alexandre,
> 
> Here's the V2 of a previous patchset I sent back in April.
> 
> Patch [1/4] was updated with Krzysztof's feedback.
> 
> Patches 2-4 are unmodified from V1 as they didn't receive any feedback.
> Patch 4 is RFC; I *think* it works, but I don't know how to test it.
> 

You should simply adjust the RTC and see whether the drift changes. The
best is to simply use chrony as this will actually tell you how much the
RTC drifts. This actually gives you the exact value to put in offset to
remove the drift.

> V1 had a 5th patch which would reset the scratchpad register on power
> loss, but was dropped following upstream feedback.
> 
> Cheers,
> - Paul
> 
> Paul Cercueil (4):
>   dt-bindings: rtc: ingenic: Rework compatible strings and add #clock-cells
>   rtc: jz4740: Use readl_poll_timeout
>   rtc: jz4740: Register clock provider for the CLK32K pin
>   rtc: jz4740: Support for fine-tuning the RTC clock
> 
>  .../devicetree/bindings/rtc/ingenic,rtc.yaml  |  32 ++++-
>  drivers/rtc/rtc-jz4740.c                      | 113 +++++++++++++++---
>  2 files changed, 129 insertions(+), 16 deletions(-)
> 
> -- 
> 2.35.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com