linux-kernel - Re: [PATCH net-next] ipvlan: minor optimization for ipvlan outbound process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cdb2fff-9eee-564d-f8df-38ff7125dad2@huawei.com>
Date:   Wed, 2 Nov 2022 11:47:42 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Eric Dumazet <edumazet@...gle.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] ipvlan: minor optimization for ipvlan outbound
 process

On 2022/11/2 11:23, Eric Dumazet wrote:
> On Tue, Nov 1, 2022 at 7:15 PM Yunsheng Lin <linyunsheng@...wei.com> wrote:
>>
>> Avoid some local variable initialization and remove some
>> redundant assignment in ipvlan outbound process.
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> 
> Really I do not see the point of such a patch, making future backports
> more difficult.

As the ipvlan outbound process is in the fast path, avoiding the
unnecessary steps might be worth the backport cost.

Anyway, it is more of judgment call, not a rule, right?

> 
> Changing old code like that should only be done if this is really necessary,
> for instance before adding a new functionality.
> .
>