| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ee6c5a96-81c4-5729-f623-4b23bc3b8e0a@kernel.org>
Date: Wed, 2 Nov 2022 17:20:43 -0400
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Billy Tsai <billy_tsai@...eedtech.com>, jdelvare@...e.com,
linux@...ck-us.net, robh+dt@...nel.org, joel@....id.au,
andrew@...id.au, lee.jones@...aro.org, thierry.reding@...il.com,
u.kleine-koenig@...gutronix.de, p.zabel@...gutronix.de,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-pwm@...r.kernel.org, BMC-SW@...eedtech.com,
garnermic@...a.com
Subject: Re: [PATCH 1/3] dt-bindings: Add bindings for aspeed pwm-tach.
On 31/10/2022 06:38, Billy Tsai wrote:
> Unlike the old design that the register setting of the TACH should based
Drop full stop in subject. Drop redundant, second "bindings" in subject.
> on the configure of the PWM. In ast26xx, the dependency between pwm and
> tach controller is eliminated and becomes a separate hardware block. They
> only shared the same base address, source clock and reset.
> This patch adds device binding for aspeed pwm-tach device which is a
> multi-function device include pwm and tach function and pwm/tach device
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> bindings which should be the child-node of pwm-tach device.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
>
> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
> ---
> .../bindings/hwmon/aspeed,ast2600-tach.yaml | 48 ++++++++++++
> .../bindings/mfd/aspeed,ast2600-pwm-tach.yaml | 76 +++++++++++++++++++
> .../bindings/pwm/aspeed,ast2600-pwm.yaml | 64 ++++++++++++++++
Split per subsystem. And Cc necessary people...
> 3 files changed, 188 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
> create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml
> create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
> new file mode 100644
> index 000000000000..838200fae30e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2021 Aspeed, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2600-tach.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Aspeed Ast2600 Tach controller
> +
> +maintainers:
> + - Billy Tsai <billy_tsai@...eedtech.com>
> +
> +description: |
> + The Aspeed Tach controller can support upto 16 fan input.
> + This module is part of the ast2600-pwm-tach multi-function device. For more
> + details see ../mfd/aspeed,ast2600-pwm-tach.yaml.
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2600-tach
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + pinctrl-0: true
> +
> + pinctrl-names:
> + const: default
These should not be needed.
> +
> +required:
> + - compatible
> + - "#address-cells"
> + - "#size-cells"
> +
> +additionalProperties:
Instead patternProperties and put them above "required:"
> + type: object
> + properties:
> + reg:
> + description:
> + The tach channel used for this node.
> + maxItems: 1
> +
> + required:
> + - reg
additionalProperties on this level of indentation.
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml
> new file mode 100644
> index 000000000000..1eaf6fab2752
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2021 Aspeed, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/aspeed,ast2600-pwm-tach.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PWM Tach controller Device Tree Bindings
Drop "Device Tree Bindings"
> +
> +description: |
> + The PWM Tach controller is represented as a multi-function device which
> + includes:
> + PWM
> + Tach
> +
> +maintainers:
> + - Billy Tsai <billy_tsai@...eedtech.com>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - aspeed,ast2600-pwm-tach
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> +
> +patternProperties:
> + "^pwm(@[0-9a-f]+)?$":
> + $ref: ../pwm/aspeed,ast2600-pwm.yaml
Full path, so: /schemas/pwm/aspeed,ast2600-pwm.yaml
Why unit addresses are optional?
> +
> + "^tach(@[0-9a-f]+)?$":
> + $ref: ../hwmon/aspeed,ast2600-tach.yaml
Ditto
Why unit addresses are optional?
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/ast2600-clock.h>
> + pwm_tach: pwm_tach@...10000 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
No underscores in node names.
> + compatible = "aspeed,ast2600-pwm-tach", "syscon", "simple-mfd";
> + reg = <0x1e610000 0x100>;
> + clocks = <&syscon ASPEED_CLK_AHB>;
> + resets = <&syscon ASPEED_RESET_PWM>;
> +
> + pwm: pwm {
> + compatible = "aspeed,ast2600-pwm";
> + #address-cells = <1>;
> + #size-cells = <0>;
No need for address/size cells. No children.
> + #pwm-cells = <3>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm0_default>;
> + };
> +
> + tach: tach {
> + compatible = "aspeed,ast2600-tach";
> + #address-cells = <1>;
> + #size-cells = <0>;
Ditto.
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_tach0_default>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
> new file mode 100644
> index 000000000000..f501f8a769df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2021 Aspeed, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Aspeed Ast2600 PWM controller
> +
> +maintainers:
> + - Billy Tsai <billy_tsai@...eedtech.com>
> +
> +description: |
> + The Aspeed PWM controller can support upto 16 PWM outputs.
s/can support/supports/
s/upto/up to/
> + This module is part of the ast2600-pwm-tach multi-function device. For more
> + details see ../mfd/aspeed,ast2600-pwm-tach.yaml.
> +
Missing $ref to pwm.yaml
> +properties:
> + compatible:
Below, same comments apply.
This is incomplete review.
Best regards,
Krzysztof
Powered by blists - more mailing lists