linux-kernel - RE: [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-pstate-ut

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR12MB6351D67868CCC8CB67882BF9F7399@DM4PR12MB6351.namprd12.prod.outlook.com>
Date:   Wed, 2 Nov 2022 04:27:11 +0000
From:   "Meng, Li (Jassmine)" <Li.Meng@....com>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        "Huang, Ray" <Ray.Huang@....com>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
CC:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@....com>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Huang, Shimmer" <Shimmer.Huang@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V5 0/5] Add tbench/gitsource new test cases for
 amd-pstate-ut

[AMD Official Use Only - General]



> -----Original Message-----
> From: Shuah Khan <skhan@...uxfoundation.org>
> Sent: Tuesday, November 1, 2022 5:27 PM
> To: Meng, Li (Jassmine) <Li.Meng@....com>; Huang, Ray
> <Ray.Huang@....com>; linux-kselftest@...r.kernel.org
> Cc: Rafael J . Wysocki <rafael.j.wysocki@...el.com>; Fontenot, Nathan
> <Nathan.Fontenot@....com>; Sharma, Deepak
> <Deepak.Sharma@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>; Huang, Shimmer
> <Shimmer.Huang@....com>; Yuan, Perry <Perry.Yuan@....com>; Du,
> Xiaojian <Xiaojian.Du@....com>; Viresh Kumar <viresh.kumar@...aro.org>;
> Borislav Petkov <bp@...en8.de>; linux-kernel@...r.kernel.org; Shuah Khan
> <skhan@...uxfoundation.org>
> Subject: Re: [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-
> pstate-ut
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On 10/31/22 04:04, Shuah Khan wrote:
> > On 10/31/22 02:49, Meng Li wrote:
> >> Hi all:
> >>
> >> First, rename amd-pstate-ut.sh to basic.sh as a basic test, mainly
> >> for AMD P-State kernel drivers. The purpose of this modification is
> >> to facilitate the subsequent addition of gitsource, tbench and other tests.
> >>
> >> Second, split basic.sh into run.sh and basic.sh.
> >> The modification makes basic.sh more pure, just for test basic kernel
> >> functions. The file of run.sh mainly contains functions such as test
> >> entry, parameter check, prerequisite and log clearing etc.
> >>
> >> Third, add tbench.sh trigger the tbench testing and monitor the cpu.
> >>
> >> Fourth, add gitsource.sh trigger the gitsource testing and monitor
> >> the cpu information.
> >>
> >> Finally, modify rst document to introduce test steps and results etc.
> >>
> >
> >>
> >> Changes from V4->V5:
> >> - selftests: amd-pstate:
> >> - - rename amd-pstate-ut.sh to basic.sh.
> >> - - split basic.sh into run.sh and basic.sh.
> >> - - modify tbench.sh to prompt to install tbench.
> >> - - modify commit messages and description informations of shell files.
> >> - Documentation: amd-pstate:
> >> - - correct spell errors.
> >>
> >
> > v5 series looks good. Please cleanup checkpatch errors in a couple of files.
> > Not too concerned about long line warnings as these seem like "echo"
> > statements with output text.
> >
> 
> Applied to linux-kselftest next now after fixing the white space error. Please
> run checkpatch in the future.
> 

Thank you very much. I will pay attention to it.

Jasmine

> thanks,
> -- Shuah