linux-kernel - Re: [PATCH v3 1/2] blk-mq: improve error handling in blk_mq_alloc_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab4991d7-4b84-df91-db45-96f31d19a871@nvidia.com>
Date:   Wed, 2 Nov 2022 05:45:34 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Jinlong Chen <nickyc975@....edu.cn>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "hch@....de" <hch@....de>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] blk-mq: improve error handling in
 blk_mq_alloc_rq_map()

On 11/1/22 20:06, Jinlong Chen wrote:
> Use goto-style error handling like we do elsewhere in the kernel.
> 
> Signed-off-by: Jinlong Chen <nickyc975@....edu.cn>
> ---

since all to blk_mq_free_tags is duplicated in the code this seems
to be the right thing to do.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck