linux-kernel - Re: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2Ib7FjwfqbcZ77h@kroah.com>
Date:   Wed, 2 Nov 2022 08:27:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Deepak R Varma <drv@...lo.com>
Cc:     outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup

On Mon, Oct 31, 2022 at 11:25:14PM +0530, Deepak R Varma wrote:
> Remove unnecessary or unused code.
> 
> Changes in v2:
>    Patch1:
>       1. Revise patch log to explain impact of the patch
>          Suggested by gregkh@...uxfoundation.org
>    Patch2:
>       1. Review other similar macro defines and clean those up as well.
>          Suggested by gregkh@...uxfoundation.org
>       2. Revise patch log to explain impact of the patch
>          Suggested by julia.lawall@...ia.fr
> 
> Deepak R Varma (2):
>   staging: rtl8192u: remove unnecessary function implementation
>   staging: rtl8192u: remove redundant macro definition
> 
>  .../staging/rtl8192u/ieee80211/ieee80211.h    | 67 -------------------
>  .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c |  6 --
>  .../rtl8192u/ieee80211/ieee80211_module.c     |  3 -
>  3 files changed, 76 deletions(-)

This series causes a build breakage:

  MODPOST Module.symvers
../ERROR: modpost: net/mac80211/mac80211: 'ieee80211_wake_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
ERROR: modpost: net/mac80211/mac80211: 'ieee80211_stop_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
make: *** [Makefile:1944: modpost] Error 2

Always test build your changes.

greg k-h