linux-kernel - Re: [PATCH] io_uring: fix two assignments in if conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F8C3CD1A-A2C0-4772-8AB6-2F2ED04A9F76@gmail.com>
Date:   Wed, 02 Nov 2022 16:06:37 +0800
From:   Xinghui Li <korantwork@...il.com>
To:     kernel test robot <lkp@...el.com>, <axboe@...nel.dk>,
        Pavel Begunkov <asml.silence@...il.com>
CC:     <llvm@...ts.linux.dev>, <oe-kbuild-all@...ts.linux.dev>,
        <io-uring@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] io_uring: fix two assignments in if conditions



在 2022/11/1 23:10，“kernel test robot”<lkp@...el.com> 写入:

>    Hi,
>
>    Thank you for the patch! Perhaps something to improve:
>
>	......
>    If you fix the issue, kindly add following tag where applicable
>    | Reported-by: kernel test robot <lkp@...el.com>
>
>    All warnings (new ones prefixed by >>):
>
>    >> io_uring/poll.c:601:7: warning: variable 'apoll' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>                       if (entry != NULL)
>                           ^~~~~~~~~~~~~
>       io_uring/poll.c:608:2: note: uninitialized use occurs here
>               apoll->double_poll = NULL;
>               ^~~~~
>       io_uring/poll.c:601:3: note: remove the 'if' if its condition is always true
>                       if (entry != NULL)
>                       ^~~~~~~~~~~~~~~~~~
>       io_uring/poll.c:594:26: note: initialize the variable 'apoll' to silence this warning
>               struct async_poll *apoll;
>                                       ^
>                                        = NULL
>       1 warning generated. 
>
>
>    vim +601 io_uring/poll.c
>
It is do a problem, I will sent v2.
Thanks a lot!
    -- 
    0-DAY CI Kernel Test Service
    https://01.org/lkp