[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202211021607.ssjymlKi-lkp@intel.com>
Date: Wed, 2 Nov 2022 16:40:09 +0800
From: kernel test robot <lkp@...el.com>
To: Michael Zaidman <michael.zaidman@...il.com>, jikos@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
linux-input@...r.kernel.org, linux-i2c@...r.kernel.org,
germain.hebert@...abb.com, Enrik.Berkhan@...a.de,
Michael Zaidman <michael.zaidman@...il.com>,
Guillaume Champagne <champagne.guillaume.c@...il.com>
Subject: Re: [PATCH v3 04/12] HID: ft260: support i2c reads greater than HID
report size
Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on hid/for-next]
[also build test WARNING on linus/master v6.1-rc3 next-20221102]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Michael-Zaidman/HID-ft260-fixes-and-performance-improvements/20221031-043557
base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link: https://lore.kernel.org/r/20221030203403.4637-5-michael.zaidman%40gmail.com
patch subject: [PATCH v3 04/12] HID: ft260: support i2c reads greater than HID report size
config: m68k-randconfig-s032-20221102
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/57eb0752edbe6db04f5b8e1161f3ad722708b8b2
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Michael-Zaidman/HID-ft260-fixes-and-performance-improvements/20221031-043557
git checkout 57eb0752edbe6db04f5b8e1161f3ad722708b8b2
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=m68k SHELL=/bin/bash drivers/hid/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/hid/hid-ft260.c:539:36: sparse: sparse: cast to restricted __be16
drivers/hid/hid-ft260.c:797:50: sparse: sparse: cast to restricted __le16
drivers/hid/hid-ft260.c:797:50: sparse: sparse: cast to restricted __le16
drivers/hid/hid-ft260.c:797:50: sparse: sparse: cast to restricted __le16
drivers/hid/hid-ft260.c:797:50: sparse: sparse: cast to restricted __le16
drivers/hid/hid-ft260.c:882:1: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] *field @@ got restricted __le16 * @@
drivers/hid/hid-ft260.c:882:1: sparse: expected unsigned short [usertype] *field
drivers/hid/hid-ft260.c:882:1: sparse: got restricted __le16 *
drivers/hid/hid-ft260.c:883:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] clock @@ got unsigned short [addressable] [usertype] clock @@
drivers/hid/hid-ft260.c:883:1: sparse: expected restricted __le16 [usertype] clock
drivers/hid/hid-ft260.c:883:1: sparse: got unsigned short [addressable] [usertype] clock
vim +539 drivers/hid/hid-ft260.c
516
517 /*
518 * A random read operation is implemented as a dummy write operation, followed
519 * by a current address read operation. The dummy write operation is used to
520 * load the target byte address into the current byte address counter, from
521 * which the subsequent current address read operation then reads.
522 */
523 static int ft260_i2c_write_read(struct ft260_device *dev, struct i2c_msg *msgs)
524 {
525 int ret;
526 int wr_len = msgs[0].len;
527 int rd_len = msgs[1].len;
528 struct hid_device *hdev = dev->hdev;
529 u8 addr = msgs[0].addr;
530 u16 read_off = 0;
531
532 if (wr_len > 2) {
533 hid_err(hdev, "%s: invalid wr_len: %d\n", __func__, wr_len);
534 return -EOPNOTSUPP;
535 }
536
537 if (ft260_debug) {
538 if (wr_len == 2)
> 539 read_off = be16_to_cpu(*(u16 *)msgs[0].buf);
540 else
541 read_off = *msgs[0].buf;
542
543 pr_info("%s: off %#x rlen %d wlen %d\n", __func__,
544 read_off, rd_len, wr_len);
545 }
546
547 ret = ft260_i2c_write(dev, addr, msgs[0].buf, wr_len,
548 FT260_FLAG_START);
549 if (ret < 0)
550 return ret;
551
552 ret = ft260_i2c_read(dev, addr, msgs[1].buf, rd_len,
553 FT260_FLAG_START_STOP_REPEATED);
554 if (ret < 0)
555 return ret;
556
557 return 0;
558 }
559
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (98118 bytes)
Powered by blists - more mailing lists