linux-kernel - [RESEND PATCH] xhci: Remove iommu condition for Renesas PCIe controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221102014340.129587-1-gehao@kylinos.cn>
Date:   Wed,  2 Nov 2022 09:43:40 +0800
From:   gehao <gehao@...inos.cn>
To:     mathias.nyman@...el.com, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     wangwenmei168@....com, xieming@...inos.cn, gehao <gehao@...inos.cn>
Subject: [RESEND PATCH] xhci: Remove iommu condition for Renesas PCIe controllers

When we use uPD720201 USB 3.0 Host Controller passthrough to VM
guest os will report follow errors and it can not working.

xhci_hcd 0000:09:00.0: Host took too long to start, waited 16000
microseconds.
xhci_hcd 0000:09:00.0: startup error -19.

Renesas controllers preserve the top half of the address in internal,
non visible registers,and end up with half the address coming from the
kernel, and the other half coming from the firmware.

For guest os,although our dev->iommu_group = NULL,but we are still under
iommu control.

This condition is not necessary,because for os with noiommu,doing
anything when there is no iommu is definitely,and when our os with
iommu,it is safe.

Signed-off-by: gehao <gehao@...inos.cn>
---
 drivers/usb/host/xhci.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 79d7931c048a..589d54ecd2a4 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -227,7 +227,6 @@ int xhci_reset(struct xhci_hcd *xhci, u64 timeout_us)
 
 static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
 {
-	struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
 	int err, i;
 	u64 val;
 	u32 intrs;
@@ -241,12 +240,8 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
 	 * changing the programming leads to extra accesses even if the
 	 * controller is supposed to be halted. The controller ends up with
 	 * a fatal fault, and is then ripe for being properly reset.
-	 *
-	 * Special care is taken to only apply this if the device is behind
-	 * an iommu. Doing anything when there is no iommu is definitely
-	 * unsafe...
 	 */
-	if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
+	if (!(xhci->quirks & XHCI_ZERO_64B_REGS))
 		return;
 
 	xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
-- 
2.25.1


No virus found
		Checked by Hillstone Network AntiVirus