linux-kernel - Re: [PATCH 2/2] mm: Use pte markers for swap errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb273d26-df8e-7c68-c81d-4d9a440aa975@redhat.com>
Date:   Wed, 2 Nov 2022 10:16:13 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Peter Xu <peterx@...hat.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Huang Ying <ying.huang@...el.com>,
        HORIGUCHI NAOYA <naoya.horiguchi@....com>,
        Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH 2/2] mm: Use pte markers for swap errors

On 30.10.22 22:41, Peter Xu wrote:
> PTE markers are ideal mechanism for things like SWP_SWAPIN_ERROR.  Using a
> whole swap entry type for this purpose can be an overkill, especially if we
> already have PTE markers.  Define a new bit for swapin error and replace it
> with pte markers.  Then we can safely drop SWP_SWAPIN_ERROR and give one
> device slot back to swap.
> 
> We used to have SWP_SWAPIN_ERROR taking the page pfn as part of the swap
> entry, but it's never used.  Neither do I see how it can be useful because
> normally the swapin failure should not be caused by a bad page but bad swap
> device.  Drop it alongside.
> 
> Reviewed-by: Huang Ying <ying.huang@...el.com>
> Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---


Acked-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb