linux-kernel - Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2I3tekSAO42r0xR@hovoldconsulting.com>
Date:   Wed, 2 Nov 2022 10:26:13 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Shazad Hussain <quic_shazhuss@...cinc.com>
Cc:     Stephen Boyd <sboyd@...nel.org>, andersson@...nel.org,
        bmasney@...hat.com, Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for
 gcc_ufs_ref_clkref_clk

On Wed, Nov 02, 2022 at 02:15:26PM +0530, Shazad Hussain wrote:
> On 11/2/2022 1:43 PM, Johan Hovold wrote:

> > Right, but if the PHYs really requires CX and it is not an ancestor of
> > the refclk then this should be described by the binding (and not be
> > hidden away in the clock driver).

> This makes sense, will be posting v2 post for the same.
> I assume this should use the Fixes tag then !

Yeah, I guess to you can add a fixes tag for the commits adding support
for sc8280xp to the UFS PHY binding and driver.

But please do check with the hardware documentation first so we get this
right this time.

I've already asked Bjorn to see what he can dig out as it is still not
clear how the two "card" refclocks (GCC_UFS_CARD_CLKREF_CLK and
GCC_UFS_1_CARD_CLKREF_CLK) are supposed to be used.

Johan