linux-kernel - Re: [GIT PULL] Crypto Fixes for 6.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2I9D3WI6g/MonEk@gondor.apana.org.au>
Date:   Wed, 2 Nov 2022 17:49:03 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [GIT PULL] Crypto Fixes for 6.1

On Fri, Oct 28, 2022 at 10:00:34AM -0700, Linus Torvalds wrote:
> 
> I'm surprised that there isn't a cra_ctxalignment field. Instead there
> is crypto_tfm_ctx_alignment(), but that is just an odd way to write
> CRYPTO_MINALIGN.

It's a micro-optimisation to elide the align operaton because
most algorithms don't need it.

I've been meaning to add a helper for it though:

https://lore.kernel.org/all/E1noNhu-00BzV4-4N@fornost.hmeau.com/

But I got side tracked by the vacillating DMA discussion.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt