linux-kernel - Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc14b1e4-2034-c70d-66b9-47da89726037@intel.com>
Date:   Wed, 2 Nov 2022 12:22:34 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse()
 return code

On 1/11/22 12:52, Matthias Schiffer wrote:
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci_am654.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>  
>  	ret = mmc_of_parse(host->mmc);
>  	if (ret) {
> -		dev_err(dev, "parsing dt failed (%d)\n", ret);
> +		dev_err_probe(dev, ret, "parsing dt failed\n");
>  		goto pm_runtime_put;
>  	}
>