linux-kernel - Re: [PATCH v2] staging: r8188eu: remove unwanted variable implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2022 16:22:06 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     outreachy@...ts.linux.dev,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: remove unwanted variable
 implementation

On Wed, Nov 02, 2022 at 01:32:30PM +0530, Deepak R Varma wrote:
> On Wed, Nov 02, 2022 at 08:29:52AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Nov 02, 2022 at 01:48:18AM +0530, Deepak R Varma wrote:
> > > Local variables intended as the function return value are
> > > initialized but their value does not change during function
> > > execution. The initial value assigned to the variable is simply
> > > returned to the caller. This makes the variable declaration
> > > unnecessary and the initial value can be directly returned.
> > >
> > > Following table lists the initial commits when the variables were first
> > > introduced but have not been used since inception:
> > >
> > > Variable  Function	File			     Inception Commit
> > > ret	  rtw_sta_flush	r8188eu/core/rtw_ap.c	     [1]
> > > ret	  amsdu_to_msdu r8188eu/core/rtw_recv.c	     [2]
> > > ret	  rtw_p2p_set	r8188eu/os_dep/ioctl_linux.c [3]
> > >
> > > [1] 'commit 9a7fe54ddc3a ("staging: r8188eu: Add source files for new driver - part 1")'
> > > [2] 'commit 1cc18a22b96b ("staging: r8188eu: Add files for new driver - part 5")'
> > > [3] 'commit a2c60d42d97c ("staging: r8188eu: Add files for new driver - part 16")'
> > >
> > > However, local variable pull of the function update_txdesc from file
> > > r8188eu/hal/rtl8188eu_xmit.c was in use prior to introduction of
> > > commit ID [4] 7bdedfef085bb65. The clean-up associated with this
> > > commit left the variable pull redundant.
> > >
> > > [4] 'commit 7bdedfef085b ("staging: r8188eu: Remove mp, a.k.a. manufacturing process, code")'
> > >
> > > The patch is produced using the following coccicheck options:
> > >    COCCI=./scripts/coccinelle/misc/returnvar.cocci
> > >    M=driver/staging/r8188eu/
> > >    MODE=patch
> > >
> > > Signed-off-by: Deepak R Varma <drv@...lo.com>
> > > ---
> > >
> > > Changes in v2:
> > >    1. Include reason for why the variable declarations are not useful. Suggested
> > >       by Julia Lawall <julia.lawall@...ia.fr>
> >
> > Does not apply to my tree at all :(
> >
> > Please rebase and resubmit.
>
> Hello Greg,
> Looks like there was another patch effort in parallel to correct this coccicheck
> complaint. I am checking if all the observations from my patch are resolved. If
> not, I will rebase and send in revised patch.

Hello Greg,
I verified and found that all the changes my patch proposed have been introduced
by parallel patches from another developer. Hence this patch can be ignored.

Thank you.
./drv

>
> Thank you.
> ./drv
>
> >
> > thanks,
> >
> > greg k-h
> >
> >
>
>
>