[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <98b02ef5-2159-5f4f-aa5b-389aba4f92e1@collabora.com>
Date: Wed, 2 Nov 2022 14:02:42 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Christian König <christian.koenig@....com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Sumit Semwal <sumit.semwal@...aro.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, noralf@...nnes.org,
Dan Carpenter <dan.carpenter@...cle.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] drm/client: Prevent NULL dereference in
drm_client_buffer_delete()
On 11/2/22 12:15, Christian König wrote:
> Am 30.10.22 um 16:44 schrieb Dmitry Osipenko:
>> The drm_gem_vunmap() will crash with a NULL dereference if the passed
>> object pointer is NULL. It wasn't a problem before we added the locking
>> support to drm_gem_vunmap function because the mapping argument was
>> always
>> NULL together with the object. Make drm_client_buffer_delete() to check
>> whether GEM is NULL before trying to unmap the GEM, it will happen on
>> framebuffer creation error.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>> Link: https://lore.kernel.org/dri-devel/Y1kFEGxT8MVlf32V@kili/
>> Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap
>> operations")
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
>
> Reviewed-by: Christian König <christian.koenig@....com>
Applied to drm-misc-next, thanks!
--
Best regards,
Dmitry
Powered by blists - more mailing lists