linux-kernel - Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y2JVWmJsprt0xnKH@sirena.org.uk>
Date:   Wed, 2 Nov 2022 11:32:42 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Venkata Prasad Potturu <venkataprasad.potturu@....com>
Cc:     Venkata Prasad Potturu 
        <venkataprasad.potturu@....corp-partner.google.com>,
        alsa-devel@...a-project.org, vsujithkumar.reddy@....com,
        Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, ssabakar@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in
 machine driver

On Wed, Nov 02, 2022 at 10:59:07AM +0530, Venkata Prasad Potturu wrote:
> On 11/1/22 20:01, Mark Brown wrote:
> > On Tue, Nov 01, 2022 at 03:15:08PM +0530, Venkata Prasad Potturu wrote:

> > Right, that's what the code does but why is this something that should
> > be controlled in this fashion?

> This machine driver is common for TDM mode and I2S mode, user can select TDM
> mode or I2S mode.

Why would the user choose one value or the other, and why would this
choice be something that only changes at module load time?  If this is
user controllable I'd really expect it to be runtime controllable.
You're not explaining why this is a module parameter.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)